Quit swallowing errors while trying to find modules

lodash / babel-plugin-lodash

Modular Lodash builds without the hassle.

Other

1.95k stars 95 forks source link

Quit swallowing errors while trying to find modules #185

Closed danny-andrews closed 6 years ago

jsf-clabot commented 7 years ago

All committers have signed the CLA.

danny-andrews commented 7 years ago

The } catch (e) {} made it really difficult to track down an error where the main field in package.json of one of my dependencies was set to a file that didn't exist because I hadn't built it yet. We could alternatively wrap the error, or write something to the console, but we shouldn't be swallowing it.

jdalton commented 6 years ago

Thank you @danny-andrews!

jdalton commented 6 years ago

@danny-andrews I had to revert this PR because it was causing errors (#202)

danny-andrews commented 6 years ago

I guess we should figure out what "expected" errors are and what "unexpected" errors are and only swallow the former.