search

lodash / lodash-webpack-plugin

Smaller modular Lodash builds.
Other
1.19k stars 63 forks source link

Update README.md #161

Closed mikob closed 5 years ago

mikob commented 5 years ago

Along the lines of #112 #127 I agree that there's no need to modify this plugin to be any more complex esp. with lodash v5 on the horizon. Instead, I think it would be very helpful to have a disclaimer about how unexpected behavior can result from not having the right feature sets enabled. I think some developers would expect not enabling the right feature sets to fail more visibly (eg. undefined) but unfortunately some of us don't discover without a few hours of digging that not having these things configured properly can cause hidden errors.

For me personally, flatten was returning a valid array yet incorrect one, so it would have been nice to know how I needed to be more careful with this plugin.

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mikob commented 5 years ago

@jdalton mind taking a quick look?

jdalton commented 5 years ago

Thank you @mikob!