lodash / lodash-webpack-plugin

Smaller modular Lodash builds.
Other
1.19k stars 63 forks source link

fix: mapping baseFlatten to head #164

Closed Crayonn closed 5 years ago

Crayonn commented 5 years ago

mapping baseFlatten to head

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

jdalton commented 5 years ago

Hi @Crayonn!

What does this fix for you?

Crayonn commented 5 years ago

Compile the _baseFlatten into a head

build like this
jdalton commented 5 years ago

I understand how the mapping works. I don't understand how head helps you here though.

Crayonn commented 5 years ago

mapping

I change 'head' to '_baseFlatten' in the mapping, then it work for me,and the mapping relationship is correct.

if it not modified like this,i will close the pull requests. sorry!

Very happy to point me wrong. 😺

jdalton commented 5 years ago

Thanks for the PR @Crayonn!

I don't think we want to map baseFlatten to head at this time.

Crayonn commented 5 years ago

sorry, You've misunderstood.Now it map baseFlatten to head. I change it, and make baseFlatten map to baseFlatten

Now: https://github.com/lodash/lodash-webpack-plugin/blob/8e1ef29368752156eeeffe6638b3ecfe9a527df5/src/mapping.js#L77 Changed: https://github.com/Crayonn/lodash-webpack-plugin/commit/8d7f2f1427d01032a8353f2de7c9529caf361686#diff-1e7757e6c10b55335d57f4031a479c5dL77