search

lodev09 / react-native-true-sheet

The true native bottom sheet experience 💩
https://sheet.lodev09.com
MIT License
394 stars 12 forks source link

add popover support for iOS #66

Closed marcosrdz closed 1 month ago

marcosrdz commented 1 month ago

https://github.com/user-attachments/assets/7b4dbfdc-d3d2-47df-8856-fb77ace8d506

vercel[bot] commented 1 month ago

@marcosrdz is attempting to deploy a commit to the Jovanni's projects Team on Vercel.

A member of the Team first needs to authorize it.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 58c0ff31 and detected 0 issues on this pull request.

View more on Code Climate.

lodev09 commented 1 month ago

Hey @marcosrdz, do you have a video showcasing this feature?

marcosrdz commented 1 month ago

Hey @marcosrdz, do you have a video showcasing this feature?

Attached video

lodev09 commented 1 month ago

I see. okay, thank you for the demo @marcosrdz.. However, I'm not sure about this. I feel like that needs to be on its own package.

TrueSheet is intended for bottom sheets and adding that option defeats that purpose. I know that iPad already handles sheet UI properly and popover is kinda something different.

Also, android needs to support something similar for consistency.

marcosrdz commented 1 month ago

I see. okay, thank you for the demo @marcosrdz.. However, I'm not sure about this. I feel like that needs to be on its own package.

TrueSheet is intended for bottom sheets and adding that option defeats that purpose. I know that iPad already handles sheet UI properly and popover is kinda something different.

Also, android needs to support something similar for consistency.

Understood. Makes sense. I'll fork the package and implement these features. I'll see how Android can get the same popover experience. Thank you!

lodev09 commented 1 month ago

@marcosrdz got it.. thank you for your contribution! Good luck :)