search

lodthe / clickhouse-playground

On-demand ClickHouse playground
https://fiddle.clickhouse.com
Apache License 2.0
56 stars 4 forks source link

update aws credential logic #43

Closed santrancisco closed 1 year ago

santrancisco commented 1 year ago

Simply check if AccessKeyID is set - if it is empty, let AWS SDK load credentials from default provider chains (See: https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html)

With this, we should be able to allow the server to use credentials in environment variable or the IAM role attached to EC2 instance.

santrancisco commented 1 year ago

@lodthe - any chance to get this in soon ? :)

lodthe commented 1 year ago

@santrancisco I hope to merge it and prepare everything for DynamoDB migration this Sunday...

lodthe commented 1 year ago

Don't worry about CI checks, I will fix them.

lodthe commented 1 year ago

Again, thanks for starting the process :) I will build a new version, test it, and prepare plan for data migration.