search

loduis / teamwork.com-project-management

PHP API for Teamwork.com
https://developer.teamwork.com/
MIT License
70 stars 59 forks source link

Fixed Teamwork Time entries empty response #23

Closed aprokopenko closed 6 years ago

aprokopenko commented 9 years ago

I found a bug while developing using your library.

If time entries return null result then the condition you wrote do not work. Correct condition when using strpos is "!== FASLE" and not >0

Would be great if you can update the repository and composer

simonschaufi commented 6 years ago

Hi, I have no idea what you are doing here but please always create a NEW branch and merge it back into master.

aprokopenko commented 6 years ago

It's a 3 years old pull request... As I can see it's still pending... As I can see someone also need it, so I will update it and make a PR from separate branch

(actually it's a pull request from my fork)

simonschaufi commented 6 years ago

somebody just commented here and deleted his comment again.

simonschaufi commented 6 years ago

Solved it myself in a new commit.

aprokopenko commented 6 years ago

cool