loeeeee / immich-in-lxc

Install Immich in LXC with optional CUDA support
30 stars 3 forks source link

Update README.md with Intel Quick Sync and clearer instructions #30

Closed martiperez closed 1 day ago

martiperez commented 4 days ago

Added description for using Intel Quick Sync. Also added clarifications regarding when to run commands with the immich user or with the sudo/root user.

loeeeee commented 2 days ago

Sorry about the delay. I was taking a rest after the exam period.

Thanks for your contribution. 😃

I took a look at the changes, and had one slight issue.

I am very open to discussion, and please feel free to propose a better solution or argue otherwise. 😃

loeeeee commented 2 days ago

Also, your pull request quality is great!

havardthom commented 2 days ago

Hello, I ended up here after going down the Immich on Proxmox rabbit hole. I will be trying out this Immich setup in lxc (with Quick Sync) this weekend. Just wanted to add my two cents to your concerns as a random bypasser.

I feel like adding a optional Quick Sync section to this guide would be a great addition and it fits naturally next to the CUDA setup. Many home server users run Proxmox on a mini PC with Intel CPU and it would be a great resource for them. Creating yet a separate guide for this section does seem inconvenient and will make the Immich on Proxmox rabbit hole deeper. Though I perfectly understand your concerns on not being able to solve issues in this section.

Perhaps a solution could be adding a disclaimer to the Quick Sync section, stating The guide maintainer can not provide support for this section, any issues regarding Quick Sync must be resolved by the community or something similar you can refer to if any issues occur.

I will atleasy try this guide soon and give my feedback :) Thank you for the great work!

martiperez commented 2 days ago

I am very open to discussion, and please feel free to propose a better solution or argue otherwise. 😃

Of course I understand! I already edited the guide accordingly (second commit). I still left a message on the section "Hardware-accelerated machine learning: Others (Optional)", but it's a very minor one pointing to an external tutorial.

I will atleasy try this guide soon and give my feedback :) Thank you for the great work!

If @havardthom tries it and it works well, you can consider bringing it back by doing another pull request (just align with @loeeeee before). @havardthom - you can still access the uncommited guide here

Sorry about the delay. I was taking a rest after the exam period.

P.S.: No worries at all! I hope you could take a good rest and that your exam results are, at least, as great as this git repo! 😃

loeeeee commented 1 day ago

@martiperez I reviewed the updated pull request. Everything looks good to me! 😸

Since the rest of the changes are desperately needed and well-received, let's merge first, and leave the Intel Quick Sync for another pull request.

loeeeee commented 1 day ago

stating The guide maintainer can not provide support for this section, any issues regarding Quick Sync must be resolved by the community

This looks like a good idea. It is not like I cannot help diagnose common script issues with Intel setup. I doubt the issues are 90% non-hardware-specific, and goofy hardware-specific problems might not be that common. 🤔

Maybe we really should have Intel Quick Sync users covered. 💭