loentar / ngrest

Fast and easy C++ RESTful WebServices framework
Apache License 2.0
464 stars 93 forks source link

build_package() issue in ngrest script #19

Closed oldmammuth closed 7 years ago

oldmammuth commented 7 years ago

in commit b0d2ee2e8e414a695342ca808b72697868a49a32, dated Dec 12, 2016,

line 769 (numbering from commit )was deleted, which read as following

MAKE=make

leaving line 752 (current numbering) with an unbound variable, MAKE:

$MAKE >make-build.log

To correct the issue, it would be sufficient to restore above line 752 the deleted line, or change $make into make

I got good results with, because I was adding make flags

make ${MAKE_FLAGS:-} >make.log || return $?

Sorry if I didn't make a pull request, but an issue is the fatest way right now, please feel free to delete it as pleased. Have a good 2017!

loentar commented 7 years ago

Thanks, it should work now.