search

lofar-astron / LofarStMan

Lofar storage manager
2 stars 1 forks source link

Fix 64-bit problem #3

Closed aroffringa closed 4 years ago

aroffringa commented 4 years ago

I believe this fixes #1 .

I've done a few fixes to make sure types are always large enough. I believe the specific issue causing this problem is in LofarStMan.cc:

  itsRegFile->seek (Int(blocknr*itsBlockSize + offset));

at lines 533 and 547. There should not be a cast to int there. With an int cast there, it limits indeed the size of the file to 31-bits. @tammojan did you add this Int cast?

BTW At first I thought this had to do with casacore's 64-bit changes, but this is completely unrelated.

tammojan commented 4 years ago

@tammojan did you add this Int cast?

I'm afraid I did, in 28847f2f. Don't remember why anymore, and it's obviously wrong. Sorry for the trouble, thanks for finding this André and Cedric!

aroffringa commented 4 years ago

Thanks Tammo Jan!