search

lofar-astron / factor

Facet calibration for LOFAR
http://www.astron.nl/citt/facet-doc
GNU General Public License v2.0
19 stars 12 forks source link

Avoid sources on facet edges #207

Closed duyhoang-astro closed 7 years ago

duyhoang-astro commented 7 years ago

Does anyone know which package controls the facet edges? And which version is required for the package? I have some sources that lay on the facet edges, even though check_edges is set to default (# check_edges = True). Below is an example image,

image

Thanks.

darafferty commented 7 years ago

Shapely (https://github.com/Toblerity/Shapely) is needed for adjustment of the facet edges.

AHorneffer commented 7 years ago

Is the source actually in the sky-model that Factor uses for the faceting? If Factor doesn't know that there is a source then it won't bother trying to avoid the source. If you don't know which file is used, you can explicitly specify it with the faceting_skymodel option.

duyhoang-astro commented 7 years ago

@darafferty: I tested a few commands provided in the link. Shapely seems to work fine without any errors.

@AHorneffer: Below is another source on the facet boundaries. The red region is new facet layout, the green one was created previously. In the green region didn't cross the source, but the red one does. So, the skymodel does contain this source, but due to some reason Shapely does not work properly inside Factor at the moment (with my environment settings)?

image

One thing I noticed was that there was an update on Python packages here, which caused problems with Pybdsm. But this was fixed by rolling back the updated Python packages. Currently it's Python 2.7.5 ...

AHorneffer commented 7 years ago

Is this solved now? Or is this still an open issue?

duyhoang-astro commented 7 years ago

@AHorneffer: I don't know if this relates to the number of facet (ndir_max). But when I changed it (ndir_max), the facet layout does not cross the source. So, I used the new layout (with different ndir_max).

I haven't tested with the current version of FACTOR. So, I am not sure if this still happens... I might close this issue for now. Please re-open if needed.