search

lofar-astron / factor

Facet calibration for LOFAR
http://www.astron.nl/citt/facet-doc
GNU General Public License v2.0
19 stars 12 forks source link

poly2sky script problems #224

Closed tikk3r closed 5 years ago

tikk3r commented 5 years ago

There's a comma missing between -f and --fits_mask in the argument parsing section: https://github.com/lofar-astron/factor/blob/daf1a090730b4341900aa4c16d552a04558ce29f/factor/scripts/poly2sky.py#L135 should read

    parser.add_argument('-f', '--fits_mask', help='Filename of fits mask', type=str, default=None)

The interp argument is also not specified/used in main. Neither affect pipeline runs, but it crashes on this when running it as a standalone script.

darafferty commented 5 years ago

Thanks! Should be fixed now.