search

lofar-astron / lofar-deploy

LOFAR software stack deployment scripts and Dockerfiles for R&D purposes
GNU General Public License v3.0
6 stars 5 forks source link

Make script is broken #13

Open tammojan opened 9 years ago

tammojan commented 9 years ago

make script doesn't work for most distros, some patches don't work. Perhaps we should write a test (perhaps even a travis test) that does make test for all distros and check that something sensible is produced, and all patches get applied.

ygrange commented 9 years ago

Good idea. We could actually do the same for the Dockerfiles as well.

ygrange commented 9 years ago

There is a bug concerning versions of patch that do not support the --follow-symlinks flag. Those will fail. A workaround is fairly simple: remove --follow-symlinks from common/routines-script.mk and common/routines-docker.mk

We'll be working on a fix soon.

ygrange commented 9 years ago

I fixed the issues with older patch versions (that don't have the --follow-symlinks flag) and the newest (that does have the flag but doesn't like working on files in other directories than the working one).

I have changed the flag from bug to enhancement so that we still keep track of the requested tests.

csbnw commented 8 years ago

I have completely removed all symlinks in commit 4a64c41 and for any patching, both the target and the patch file itself are now copied to temporary files before actually calling patch. There is no need for the --follow-symlinks flag anymore.

I think that the issue is hereby resolved and make script should now work for all distros.

ygrange commented 8 years ago

Well, I kept this one open for the last sentence actually: It would be great to define a fast test to see if everything we expect is in the deploy script. The problem that such a test does pose some sort of chicken or egg problem...