loft-sh / cluster-api-provider-vcluster

Mozilla Public License 2.0
75 stars 23 forks source link

Add quickstart with kind and nginx #10

Closed oscr closed 2 years ago

oscr commented 2 years ago

Hi :wave:

Great project! Here is a draft for a little larger quickstart example to just show of how awesome this project is.

Any and all feedback is welcome

Best

oscr commented 2 years ago

Awesome! Thank you for your contribution. I am happy to merge it as is, but you called this a draft, so just let me know if you plan to add anything else to this, or whether I can go ahead and merge. :)

Great to hear! I will try out your advice, read everything again and push the changes.

Should I squash my commits as is the case in CAPI project?

matskiv commented 2 years ago

Sounds good, thank you. Yes, squashing commits would be nice :)

matskiv commented 2 years ago

Oh, sorry @oscr, we merged the PR too soon. Feel free to submit a follow-up PR if decide to make those changes. Sorry for the inconvenience.

oscr commented 2 years ago

No problem at all @matskiv! I will just make a new pr with the suggested changes. Thanks for the quick feedback!