Closed oscr closed 2 years ago
Awesome! Thank you for your contribution. I am happy to merge it as is, but you called this a draft, so just let me know if you plan to add anything else to this, or whether I can go ahead and merge. :)
Great to hear! I will try out your advice, read everything again and push the changes.
Should I squash my commits as is the case in CAPI project?
Sounds good, thank you. Yes, squashing commits would be nice :)
Oh, sorry @oscr, we merged the PR too soon. Feel free to submit a follow-up PR if decide to make those changes. Sorry for the inconvenience.
No problem at all @matskiv! I will just make a new pr with the suggested changes. Thanks for the quick feedback!
Hi :wave:
Great project! Here is a draft for a little larger quickstart example to just show of how awesome this project is.
Any and all feedback is welcome
Best