loft-sh / component-chart

Kubernetes Component Chart - Helm Chart for Application Components in Kubernetes
https://devspace.sh/component-chart/docs/introduction
Apache License 2.0
32 stars 39 forks source link

volumeClaimsTemplate is generated for Deployments #104

Closed zadigus closed 1 year ago

zadigus commented 1 year ago

While expected for a StatefulSet, the volumeClaimsTemplate property is unexpected for a Deployment. Generating that property for a Deployment makes it hard to scan the rendered yaml manifests by devspace (e.g. with trivy or terrascan).

zadigus commented 1 year ago

To fix the issue, it suffices to wrap the volumeClaimTemplates with

{{- if eq $kind "StatefulSet" }}

{{- end }}
lizardruss commented 1 year ago

Hello! Thanks for reporting. This should be fixed in an upcoming release.