search

loft-sh / component-chart

Kubernetes Component Chart - Helm Chart for Application Components in Kubernetes
https://devspace.sh/component-chart/docs/introduction
Apache License 2.0
32 stars 39 forks source link

Add missing quotes for hosts #31

Closed WilliamDASILVA closed 3 years ago

WilliamDASILVA commented 3 years ago

Since hosts can have special characters "*.my-domain.tld", it must be quoted, otherwise getting an error:

[fatal]  Error deploying api: Unable to deploy helm chart: YAML parse error on component-chart/templates/ingress.yaml: error converting YAML to JSON: yaml: line 33: did not find expected alphabetic or numeric character

fixes #32

FabianKramm commented 3 years ago

@WilliamDASILVA thanks for opening this PR! Looks good to me!