search

loft-sh / devpod-provider-aws

DevPod on AWS
Mozilla Public License 2.0
13 stars 8 forks source link

Feature: Multiple security groups #20

Closed marklarr-gfm closed 1 year ago

marklarr-gfm commented 1 year ago

For organizations with more complex security group requirements, it would be helpful to be able to pass multiple security group ID's to devpod as a comma-separated string, eg

AWS_SECURITY_GROUP_IDS=111,222,333,444

The comma-separated security groups would need to be parsed into a Go array and passed into the SecurityGroupIds of &ec2.RunInstancesInput: https://github.com/loft-sh/devpod-provider-aws/blob/ca830cc2b0f530436475ba29791391f80458ab6a/pkg/aws/aws.go#L598-L617

FabianKramm commented 1 year ago

@marklarr-gfm thanks for creating this issue! Sounds like a good idea, I guess we could support that!