loft-sh / devpod-provider-aws

DevPod on AWS
Mozilla Public License 2.0
13 stars 8 forks source link

[WIP] feat: Determine VPC ID based on tagging #38

Closed roehrijn closed 1 day ago

roehrijn commented 2 days ago

This PR allows to have neither a VPC ID nor a Subnet ID configured for the provider. It tries to determine the VPC id in these cases by looking for a devpod:devpod tag on the VPCs or, if no VPC is found, takes the default VPC.

As taking a subnet out of the default VPC when none is specified is also the default behavior of ec2:RunInstance, this should not break any existing semantics but makes determination of VPC and Subnet more explicit.

Jan Roehrich jan.roehrich@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

roehrijn commented 1 day ago

closing this in favor of #39