Closed roehrijn closed 2 days ago
Thanks for the contribution @roehrijn! This looks very useful. I left just a couple of minor remarks / questions. Could you also comment on the PR a brief description of how you tested these changes. Many thanks
Could you also comment on the PR a brief description of how you tested these changes. Many thanks
of course, going to add that soon. What I can say so far: I prepared resources in AWS accounts for every situation which could happen while traversing GetSubnet()
. In other words, I think I covered every branch in that function during my tests.
How I tested:
AWS_SUBNET_ID
-> Subnet is choosen :heavy_check_mark: AWS_SUBNET_ID
-> least occupied subnet is choosen :heavy_check_mark: AWS_SUBNET_ID
+ set availibility zone through AWS_AVAILABILITY_ZONE
-> least occupied subnet in desired availability zone is choosen :heavy_check_mark: devpod:devpod
. No AWS_...
environment variables except credentials -> least occupied tagged subnet is choosen :heavy_check_mark: devpod:devpod
. Availability zone set through AWS_AVAILABILITY_ZONE
-> subnet in desired AZ is choosen :heavy_check_mark: devpod:devpod
. VPC ID set through AWS_VPC_ID
-> tagged subnet in desired VPC is choosen :heavy_check_mark: AWS_VPC_ID
-> least occupied subnet in default VPC with public IP assignment enabled is choosen :heavy_check_mark:
This PR:
GetSubnet()
function instead of having it partly inCreate()
andGetSubnetID()
.devpod:devpod
tag without providing a VPC ID. I think this was a bug. The code required to have a VPC ID specified in this case, however it didn't do anything with the value in this decision branch.Jan Roehrich jan.roehrich@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum