feat: add VPC, Subnet, SG selection. Move from tokens to instance-profile for provider shutdown - Githubissues

loft-sh / devpod-provider-aws

DevPod on AWS

Mozilla Public License 2.0

13 stars 8 forks source link

feat: add VPC, Subnet, SG selection. Move from tokens to instance-profile for provider shutdown #5

Closed 89luca89 closed 1 year ago

89luca89 commented 1 year ago

Some quality of life improvements:

Add ability to specify a VPC
Add ability to specify a Subnet for the instance
Add ability to specify a Security Group for the instance
Add ability to specify a Instance Profile ARN for the instance

Also:

migrate from aws-sdk-v1 to v2 to support SSO logins

Also move from using a session token, to instance profile for shutting down. If shutdown this way fails, it will fallback to regular shutdown.

Resolves ENG-1430 Resolves ENG-1428 Resolves ENG-1447 Resolves ENG-1432 Resolves ENG-1423 Resolves #3 Resolved #2 Resolves https://github.com/loft-sh/devpod/issues/313 Resolves https://github.com/loft-sh/devpod/issues/315 Resolves https://github.com/loft-sh/devpod/issues/309 Resolves https://github.com/loft-sh/devpod/issues/333