loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
8.73k stars 328 forks source link

Remove redundant error checks #1120

Closed furkansenharputlu closed 2 months ago

furkansenharputlu commented 3 months ago

This PR removes the repeating redundant error checks:

err := someFunc()
if err != nil {
   return err
} 

return nil

Instead, directly returning removes redundancy and makes code more readable like this:

return someFunc()
furkansenharputlu commented 2 months ago

This is very disrespectful. There is a contribution. Even you don’t merge, you write a comment why you closed.

pascal-breuninger commented 2 months ago

Hey @furkansenharputlu, you’re right, sorry! While we value the time you spent on the pr, it adds more noise than value in my opinion