search

loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
9.53k stars 345 forks source link

Log and wrap error when setting up loft platform #1266

Closed bkneis closed 1 month ago

bkneis commented 2 months ago

A user reported an error setting up the loft platform

https://app.usepylon.com/issues?conversationID=4a04f1ed-4a71-47e9-8b15-46edea30fdb3

Unfortunately, we didn't log or return the error so it is difficult to debug. This PR addresses the problem by wrapping the platform error and returning it.

NOTE: Is returning the error correct? I was unsure on expected behaviour, if we can't get the executable or port number we seem to return the error. But if the loft platform access error'd then we simply logged it. If we should NOT return the error I can update the PR to simply log the wrapped error.

UPDATE: I removed returning the error as this could cause more trouble than solve until we know why the bellow happens.

UPDATE: I reproduced the error locally by simply running devpod up https://github.com/microsoft/vscode-remote-try-go

08:26:38 error failure in setting up Loft Platform access: 08:26:38 info 07:26:37 fatal unknown flag: --port
08:26:38 fatal inner tunnel: Process exited with status 1

These are the resulting logs. I SSH'd onto the workspace and found that the entire setup-loft-access command was missing from devpod agent container.

@janekbaraniewski can you see any way that the command would not be present? I thought we scp'd the devpod binary over the container, it's odd my local devpod had the command but on the workspace not.

janekbaraniewski commented 2 months ago

LGTM, as long as there is no reason we didn't error there in the first place 😅