search

loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
9.53k stars 345 forks source link

Feature/naming-updates #1275

Open bkneis opened 2 months ago

bkneis commented 2 months ago

I have added some docblocks and performed some re factoring as I was looking around the code to check if the docs were correct. Some of this was making certain statements more idiomatic but mostly it was renaming. I found a lot of the code had long fully qualified names and duplicate words once the package identifier was included, i.e. devcontainer.FindDevContainer. I know naming is very subjective so I only changed what I thought was awkward to read.

bkneis commented 1 month ago

@pascalbreuninger Just finished updating this PR, all of your comments but one should be addressed, including name changes :) Just one remark on your comment, let me know what you think and if I should remove

bkneis commented 1 month ago

Fixes https://github.com/loft-sh/devpod/issues/1235 and https://github.com/loft-sh/devpod/issues/1247 and https://github.com/loft-sh/devpod/issues/1187