loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
9.46k stars 343 forks source link

Add more colors for failed/successfuls steps on devpod terminal #705

Open eralumin opened 1 year ago

eralumin commented 1 year ago

image

I was stupidly waiting for an ssh process to run in background for an unknown need of DevPod and thought it didn't worked.

Maybe we could add Green color for those kind of steps when user action is needed?

pascalbreuninger commented 1 year ago

Hey @kmarilleau, thanks for opening the issue. We can definitely do a better job of letting you know the command succeeded in the UI, wouldn't change the cli output for this though

s-vamshi commented 1 year ago

@pascalbreuninger I would like to work on this issue, so we need to change colour of something to show that command has run successfully in desktop UI right?

pascalbreuninger commented 1 year ago

@s-vamshi, that'd be cool. We can either show a toast or show a message above the terminal based on the result. We currently handle this in the Actions.tsx file. You can check the action.data.status field for the result

s-vamshi commented 1 year ago

How would it be if we use react toastify? Any thoughts?

pascalbreuninger commented 1 year ago

would prefer to stick to chakra ui because we're using that for other toasts as well :) https://chakra-ui.com/docs/components/toast/usage

s-vamshi commented 1 year ago

Sure will use chakra ui

sarojregmi200 commented 1 year ago

Hello there, @s-vamshi and @pascalbreuninger is this issue being worked upon, I don't see anyone being assigned to this issue,

If no one is working on this issue I would like to give it a try.

s-vamshi commented 1 year ago

@sarojregmi200 I caught up with some work, I am working on it

sarojregmi200 commented 1 year ago

Great, you are good to go, then I was just wondering if it was not being worked upon. Good luck with the work @s-vamshi

Danish0703 commented 2 weeks ago

assign it to me