search

loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
8.76k stars 328 forks source link

Password field is shown in clear text when adding a new workspace #975

Closed havardAasen closed 6 months ago

havardAasen commented 6 months ago

What happened?
Using a provider that has a password field in provider.yaml. This password is shown in clear text when I create a new workspace. new_workspace

If editing, the password field is masked correctly. new_workspace-edit_provider

What did you expect to happen instead?
The password field should be masked.

How can we reproduce the bug? (as minimally and precisely as possible)

The specific field has this in the provider.yaml:

UIA_TOKEN:
  description: Token to authenticate with UiA.
  type: string
  required: true
  password: true
  global: true

Local Environment:

DevPod Provider:
I'm using a custom provider, but any provider with a password field should do.

89luca89 commented 6 months ago

Thanks for reporting @havardAasen will take a look!

pascalbreuninger commented 6 months ago

fixed with #985