feat: add support for devcontainer up --workspace-env-file

loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.

https://devpod.sh

Mozilla Public License 2.0

8.44k stars 311 forks source link

feat: add support for devcontainer up --workspace-env-file #978

Closed eduardodbr closed 3 months ago

eduardodbr commented 3 months ago

Fixes #827

Each file from the list is parsed for key value pairs in the format key=value and merged with the remaining --workspace-env variables.

89luca89 commented 3 months ago

Thanks a lot @eduardodbr for the PR!

Just a couple of adjustments :smile: great work, thanks!

eduardodbr commented 3 months ago

Thanks a lot @eduardodbr for the PR!

Just a couple of adjustments 😄 great work, thanks!

Done the suggested changes, thanks. Also changed workspace-env-file to be StringSliceVar instead of StringArrayVar, this way it already parses the arguments as comma-separated list of filenames

89luca89 commented 3 months ago

Thanks a lot @eduardodbr LGTM, running the test suite, and if all is green will merge :+1:

89luca89 commented 3 months ago

Thanks a lot!