search

loft-sh / devpod

Codespaces but open-source, client-only and unopinionated: Works with any IDE and lets you use any cloud, kubernetes or just localhost docker.
https://devpod.sh
Mozilla Public License 2.0
8.44k stars 310 forks source link

Add docker builder option to provider #987

Closed aacebedo closed 2 months ago

aacebedo commented 3 months ago

This PR solves #984 by first checking if podman is used when buildxExists is called and return true in this case. It also adds a DOCKER_BUILDER option to the provider in order to choose easily between the 2 builders.

aacebedo commented 3 months ago

@pascalbreuninger can you have a look to this one and give me some feedback please?

aacebedo commented 3 months ago

@aacebedo thanks for the PR! Got a couple of comments and want to make sure tests are still working

Thanks for the review! Yes I will solve the e2e tests.

aacebedo commented 2 months ago

@aacebedo thanks for the PR! Got a couple of comments and want to make sure tests are still working

Thanks for the review! Yes I will solve the e2e tests.

@pascalbreuninger I have fixed the test. I have added a workflow dispatch event to E2E test to ease the next PRs. Don't know if it is ok for you but it helped me a lot as I do not have the same environment as the CI.

pascalbreuninger commented 2 months ago

@pascalbreuninger I have fixed the test. I have added a workflow dispatch event to E2E test to ease the next PRs. Don't know if it is ok for you but it helped me a lot as I do not have the same environment as the CI.

One small cleanup remaining and we're good to merge. The workflow dispatch makes sense 👍 Also just doubled checked and apparently only collaborators and above can trigger it in the main repo. Just wanted to be sure we're not opening an avenue for burning through our Github Action minutes 😅