search

loft-sh / loft

Namespace & Virtual Cluster Manager for Kubernetes - Lightweight Virtual Clusters, Self-Service Provisioning for Engineers and 70% Cost Savings with Sleep Mode
https://loft.sh/docs/introduction
Other
738 stars 65 forks source link

Added "&& rm -f loft" to the CLI install commands. For consistency we… #223

Closed mpetason closed 1 year ago

mpetason commented 1 year ago

… may want to match the install guides of other projects like vcluster.

netlify[bot] commented 1 year ago

Deploy Preview for loft-docs ready!

Built without sensitive environment variables

Name Link
Latest commit 0205fc6feb98992a6add6979ecea3f0c8ca21bc3
Latest deploy log https://app.netlify.com/sites/loft-docs/deploys/63e86e010ffb0b0008d221c2
Deploy Preview https://deploy-preview-223--loft-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

FabianKramm commented 1 year ago

@mpetason thanks a lot for the PR! LGTM!

mpetason commented 1 year ago

@FabianKramm - no problem, the docs are great, I just went through installing a couple of the projects under loft and noticed vcluster has cleanup after install. Maybe this file is maintained somewhere else and is updated through syncing? It looks like the original sync failed:

https://github.com/loft-sh/loft/actions/runs/4161966921/jobs/7200558227

The file gets updated with the merge, but then it is reverted with:

https://github.com/loft-sh/loft/commit/c7f9541ec5437669df2e700fd23791ecd9f56c1c

carlmontanari commented 1 year ago

hey @mpetason yeah just saw this this morning and have it on my to do list to investigoogle the sync issues, thanks for following up! hopefully will get it sorted out this week some time!