search

loft-sh / vcluster-docs

https://vcluster.com/docs
Apache License 2.0
5 stars 26 forks source link

Updated isolated workloads formatting and info for local deployment #187

Closed ThomasK33 closed 4 months ago

ThomasK33 commented 4 months ago

Added an info box about setting --expose-local=false when running vcluster create locally. Also added a missing yaml annotation to the last code block.

Preview link: https://deploy-preview-187--vcluster-docs-site.netlify.app/docs/vcluster/deploy/topologies/isolated-workloads

netlify[bot] commented 4 months ago

Deploy Preview for vcluster-docs-site ready!

Name Link
Latest commit 81dedd306c715dbad6ca9c88aaca39bc43142aa3
Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/668fe6c739ab6200080c4eec
Deploy Preview https://deploy-preview-187--vcluster-docs-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ThomasK33 commented 4 months ago

@deniseschannon I can have it run through Grammarly if that helps.

This PR mainly includes lint fixes from markdownlint and that one added info box for a local setup.

I updated the PR with your fixes.

deniseschannon commented 4 months ago

@ThomasK33 There are still notes about how it could be a security risk in the last paragraph that I would like updated. Since this is a default option, why would we have a default option that has security risks? Therefore I want it changed to not include the idea of security risks could exist.