default clusterRole ineffecient for vcluster serviceaccount

loft-sh / vcluster-plugins

The plugin repository for vcluster. Extend virtual Kubernetes clusters with plugins.

11 stars 6 forks source link

default clusterRole ineffecient for vcluster serviceaccount #42

Open jbarfield opened 10 months ago

jbarfield commented 10 months ago

I had to update the clusterrole RBAC permissions in order for this plugin to work.

k3s version 1.6.29 on k8s 1.26.5 (kubespray).

Yaml like so:

- apiGroups:
  - cert-manager.io
  resources:
  - certificates
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - cert-manager.io
  resources:
  - issuers
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - ""
  resources:
  - secrets
  verbs:
  - get
  - list
  - watch

FabianKramm commented 9 months ago

@jbarfield thanks for creating this issue! Would you mind to create a small PR for this?

jbarfield commented 9 months ago

Sure thing. I just received this notification or I would have done it then.

jbarfield commented 9 months ago

PR #43 opened to address this issue.

jbarfield commented 9 months ago

Just wanted to bump this issue in case the previous notification regarding PR43 did not get seen.