search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.31k stars 402 forks source link

move topologySpreadConstraints to values #1880

Closed tamasborsstriva closed 3 months ago

tamasborsstriva commented 3 months ago

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement /kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #1834

Please provide a short message that should be published in the vcluster release notes make topologySpreadConstraints configurable from helm chart/values

What else do we need to know?

netlify[bot] commented 3 months ago

Deploy Preview for vcluster-docs canceled.

Name Link
Latest commit ac633e026238bca87ce31be470326e87104b4519
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/667d9c72a523120008da250e
FabianKramm commented 3 months ago

@tamasborsstriva thanks a lot for the PR! You need to add that to the golang struct as we generate the schema and values.yaml based off that or otherwise the tests will fail.

tamasborsstriva commented 3 months ago

@FabianKramm thank you, I have just updated the PR

heiko-braun commented 3 months ago

@tamasborsstriva Can you run 'go run hack/schema/main.go' before committing your changes? Besides that, can you take a look at the test failures?