search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.15k stars 368 forks source link

chore: rename activate flag to add and move to helm flags #1881

Closed johannesfrey closed 1 week ago

johannesfrey commented 1 week ago

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #

Please provide a short message that should be published in the vcluster release notes Renamed activate flag to add in vcluster create in order to be more consistent

What else do we need to know? Also moved the field to helm flags, otherwise it would appear also in vcluster platform create vcluster where a --add=false does not make sense?!

netlify[bot] commented 1 week ago

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit 94aa5a8cac31d73fe2025e2d038468a6de5d1a86
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6673df314fc7f500081d3a53