search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.27k stars 398 forks source link

default distribution is k8s, not k3s #2095

Closed dimbleby closed 1 week ago

dimbleby commented 2 weeks ago

What happened?

The docs claim that the default distribution used is k3s. But it isn't, it is k8s.

What did you expect to happen?

I expected the docs and the behaviour to agree

How can we reproduce it (as minimally and precisely as possible)?

vcluster create test-cluster

Anything else we need to know?

docs https://github.com/loft-sh/vcluster/blob/29efe2556088d63008a297de10cc480718c947d3/docs/pages/deploying-vclusters/supported-distros.mdx#L6

default https://github.com/loft-sh/vcluster/blob/29efe2556088d63008a297de10cc480718c947d3/chart/templates/_distro.tpl#L29

Host cluster Kubernetes version

```console $ kubectl version # paste output here ```

vcluster version

```console $ vcluster --version # paste output here ```

VCluster Config

``` # My vcluster.yaml / values.yaml here ```
FabianKramm commented 2 weeks ago

@dimbleby thanks for creating this issue! The docs that are part of the repo are the old docs, if you go to vcluster.com/docs you'll end up at the new docs, which are located in the github.com/loft-sh/vcluster-docs repository and it looks correct there.

dimbleby commented 2 weeks ago

I see, thanks

for what it's worth I have spent the last five minutes looking and failed to find where that newer discussion of distributions is published. Probably it's there somewhere?

and obviously it's confusing for this repository to be carrying the baggage of stale docs

but if the k8s default is indeed intended: well that answers my question, thank you. Feel free to close this out: or, if you prefer, to keep it to track cleaning up.