search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.92k stars 427 forks source link

Check if vcluster chart version supports k8s version #2114

Closed rmweir closed 2 months ago

rmweir commented 2 months ago

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) Fixes ENG-4480

Prior, an extra value, distro.k8s.version, could be set for a vcluster with a version that does not support the distro.k8s.version field. This would lead to a panic in vcluster. Now, the value is only set if the vcluster chart version is known to support it. Otherwise, it is left empty, leading to the omission of the field and no panic.

Please provide a short message that should be published in the vcluster release notes Fixed an issue where older vcluster versions may panic due to being passed an unsupported value.

What else do we need to know?

netlify[bot] commented 2 months ago

Deploy Preview for vcluster-docs ready!

Built without sensitive environment variables

Name Link
Latest commit 7f441bfc82ea825b18946955fcb2b45588a35e92
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66d8edfce4b858000893f307
Deploy Preview https://deploy-preview-2114--vcluster-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.