search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.92k stars 427 forks source link

Changes fallback ns to vcluster-platform #2147

Closed zerbitx closed 2 months ago

zerbitx commented 2 months ago

Adds function to look up loft deployment's namespace

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #ENG-4560

Please provide a short message that should be published in the vcluster release notes Tries to look up the platform install's deployment to get the namespace rather than assuming "loft" if the user doesn't specify and the flag default isn't vcluster-platform.

netlify[bot] commented 2 months ago

Deploy Preview for vcluster-docs canceled.

Name Link
Latest commit 4e829114874d12d7c4ef910da1fe81109a4094e4
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66ebcfe09aab690008feb6cc
loft-bot commented 2 months ago

💔 All backports failed

Status Branch Result
❌ v0.20 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2147

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

zerbitx commented 2 months ago

💚 All backports created successfully

Status Branch Result
✅ v0.20

Questions ?

Please refer to the Backport tool documentation