search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.92k stars 427 forks source link

add --ca-data flag to vcluster platform add cluster command to allow … #2153

Closed hidalgopl closed 2 months ago

hidalgopl commented 2 months ago

…installing loft agent with additionalCA

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves ENG-4521

Please provide a short message that should be published in the vcluster release notes Fixed an issue where vcluster platform add cluster was setting additionalCA for loft-agent when it was set in cluster access. Instead, now user can pass additionalCA for given loft agent as a command flag

What else do we need to know?

netlify[bot] commented 2 months ago

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit a11b0b5f4f4f91964a54555441e46c6d3608d63d
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66eaf03c22a42800083b4fe3
loft-bot commented 2 months ago

💔 All backports failed

Status Branch Result
❌ v0.20 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2153

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details