search

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.92k stars 427 forks source link

Create sub-directories in config for versions #2181

Open rmweir opened 2 months ago

rmweir commented 2 months ago

Some vcluster config logic is version specific. Splitting the config package into version specific sub-directories helps maintain backwards compatibility for package consumers. The subdirectories allow us to use version specific code as needed without carrying it forward to newer versions, creating unnecessary technical debt. Separate go module versions were proposed as an alternative but were rejected in favor of sub-directories for now, as sub-directories are simpler to implement and does not necessitate consumers to import multiple modules.

What issue type does this pull request address? (keep at least one, remove the others) /kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #

Please provide a short message that should be published in the vcluster release notes

What else do we need to know?

netlify[bot] commented 2 months ago

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit 9485d98353b9818078b3bd18d336cdac7bdf59a2
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66f9660b64ee1200083d9390