loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.
https://www.vcluster.com
Apache License 2.0
6.92k stars 426 forks source link

fix: Skip trying to dial an MX record's domain #2268

Closed zerbitx closed 1 week ago

zerbitx commented 1 week ago

What issue type does this pull request address? (keep at least one, remove the others) /kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible) resolves #ENG-5104

What else do we need to know?

Some ISPs block the SMTP ports so trying to dial will always fail even though the email is valid. This changes it to accept the email address as long as the domain returns at least one MX record.

netlify[bot] commented 1 week ago

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
Latest commit 25c4de1394b08a89d8f46b2db357b49bd92ef859
Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/672e49759f86710008e6b0d6