k3s Helm template for statefulset: volumes indentation

loft-sh / vcluster

vCluster - Create fully functional virtual Kubernetes clusters - Each vcluster runs inside a namespace of the underlying k8s cluster. It's cheaper than creating separate full-blown clusters and it offers better multi-tenancy and isolation than regular namespaces.

https://www.vcluster.com

Apache License 2.0

6.26k stars 398 forks source link

k3s Helm template for statefulset: volumes indentation #359

Closed julienlefur closed 2 years ago

julienlefur commented 2 years ago

The correct indentation should be 6 here and not 8. This is causing a problem when deploying a vcluster with k3s with extra volumes:

https://github.com/loft-sh/vcluster/blob/159f3ed76be6bb6f288683e3e705a000ae429e8a/charts/k3s/templates/statefulset.yaml#L61

FabianKramm commented 2 years ago

@julienlefur thanks for reporting this issue! Yes you are correct, this only occurs though if you set storage.persistence: false in the values.yaml as well. We'll fix this for the next version

FabianKramm commented 2 years ago

@julienlefur closing as this should be fixed