search

log-oscon / Standards

Coding standards and whatnot.
https://log-oscon.github.io/Standards/
MIT License
7 stars 0 forks source link

Create php.ruleset.xml #12

Closed xipasduarte closed 7 years ago

xipasduarte commented 8 years ago

Custom exceptions to WordPress Coding standards in log's Standards.

csrui commented 8 years ago

Porque é que estamos especificamente a ignorar os Yoda?

s3rgiosan commented 8 years ago

@csrui because most of us do not like them. It's unnatural 😄

s3rgiosan commented 8 years ago

Besides, nothing prevents you from using them in your project 😉

csrui commented 8 years ago

Ignore rules I must not. If yoda you not like, train I must. Use the fork I shall...

csrui commented 8 years ago

Quanto ao Generic.Files.LowercasedFilename.NotFound acho que pelo menos um warning devia gerar para ter pelo menos uma referência visual a lembrar da nomenclatura parva a que o wordpress obriga :p

s3rgiosan commented 8 years ago

@csrui we don't use the WordPress class naming conventions, that's why the ignore rule is here. Same applies to the yoda conditions, that most of us don't use.

csrui commented 8 years ago

@s3rgiosan By not using WordPress conventions, we must / should use some other. Which is it? And shouldn't be defined there?

And where the hell do I approve this?

s3rgiosan commented 8 years ago

@csrui Maybe it should. This is a starting point. Please make suggestions 😉

s3rgiosan commented 8 years ago

@csrui "Files changed" tab > "Review chagens" green dropdown

csrui commented 8 years ago

I am :)