search

log2timeline / dfdatetime

Digital Forensics date and time
Apache License 2.0
23 stars 15 forks source link

Changes to GolangTime to support nanosecond precision formatted string #264

Closed sydp closed 11 months ago

sydp commented 1 year ago

Add method to copy from a nanosecond precision time string:

YYYY-MM-DDThh:mm:ss.##########Z
YYYY-MM-DDThh:mm:ss.##########[+-]##:##

Fixes #263

codecov[bot] commented 1 year ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f774504) 96.15% compared to head (4e3f69d) 95.41%. Report is 1 commits behind head on main.

Files Patch % Lines
dfdatetime/golang_time.py 68.25% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ========================================== - Coverage 96.15% 95.41% -0.75% ========================================== Files 24 24 Lines 2316 2377 +61 ========================================== + Hits 2227 2268 +41 - Misses 89 109 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joachimmetz commented 11 months ago

@sydp what is the status of this PR?

sydp commented 11 months ago

@sydp what is the status of this PR?

PTAL when you can, thanks.

joachimmetz commented 11 months ago

@sydp PTAL at https://github.com/log2timeline/dfdatetime/pull/270 see if that solves the problem you are trying to solve, without adding a nanoseconds specific method.

joachimmetz commented 11 months ago

Closing this in favor of https://github.com/log2timeline/dfdatetime/pull/270