search

log2timeline / l2tscaffolder

Scaffolders for bootstrapping development of open source forensics tools.
http://l2tscaffolder.readthedocs.io/
Apache License 2.0
6 stars 9 forks source link

Adding the scaffolder manager and interface, #12 #22

Closed kiddinn closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #22 into master will decrease coverage by 1.26%. The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   99.26%   97.99%   -1.27%     
==========================================
  Files          51       54       +3     
  Lines        1090     1198     +108     
==========================================
+ Hits         1082     1174      +92     
- Misses          8       24      +16
Impacted Files Coverage Δ
plasoscaffolder/lib/errors.py 100% <100%> (ø)
plasoscaffolder/scaffolders/interface.py 65.85% <65.85%> (ø)
plasoscaffolder/scaffolders/manager.py 96.82% <96.82%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28ba3b9...d7bd885. Read the comment docs.

kiddinn commented 6 years ago

Responded to comments, except the main one, pending further discussions.

kiddinn commented 6 years ago

Renamed plugins to scaffolders

Onager commented 6 years ago

@kiddinn I made a couple of little fixes, but it looks like there's some more to do here - can you please fix the lint errors and conflicts?

kiddinn commented 6 years ago

all merge conflicts fixed as well as linter issues