Closed kiddinn closed 5 years ago
Merging #56 into master will increase coverage by
0.83%
. The diff coverage is93.93%
.
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 80.8% 81.64% +0.83%
==========================================
Files 27 29 +2
Lines 969 1035 +66
==========================================
+ Hits 783 845 +62
- Misses 186 190 +4
Impacted Files | Coverage Δ | |
---|---|---|
l2tscaffolder/scaffolders/__init__.py | 100% <100%> (ø) |
:arrow_up: |
l2tscaffolder/scaffolders/turbinia_job_task.py | 100% <100%> (ø) |
|
l2tscaffolder/scaffolders/turbinia.py | 92.85% <92.85%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7fb162c...6191aab. Read the comment docs.
Cool! Should we maybe have this generate the Task template at the same time?
@kiddinn: You've probably seen this already, but here's the docs on how to create a Job/Task right now: https://github.com/google/turbinia/blob/master/docs/developing-new-tasks.md
For most of the current Jobs and Tasks, there is a 1:1 Job:Task mapping (e.g. 1 PlasoJob -> 1 PlasoTask), but we're starting to create and plan for more complex Jobs/Tasks that split up the Jobs into multiple Tasks. There's a little more documentation on Jobs vs. Tasks here: https://github.com/google/turbinia/blob/master/docs/how-it-works.md
wIll add a task file generation to this scaffolder as well
I've asked @aarontp to take another look as well, but I added the task generation and renamed files. Ready for another round.
need to rebase and add minor corrections after the push of init file changes got pushed in
again, a bunch of other files got mangled in, closing this PR and opening a new one
Adding a new scaffolder to generate jobs for Turbinia, part of #49