log2timeline / l2tscaffolder

Scaffolders for bootstrapping development of open source forensics tools.
http://l2tscaffolder.readthedocs.io/
Apache License 2.0
6 stars 9 forks source link

Bugfix for SQLite plugin when "SELECT *" is used as a SELECT statement #72

Closed kiddinn closed 5 years ago

kiddinn commented 5 years ago

SQLite plugins should not have a "SELECT *" statements, the column names that are selected should be explicit.

If you attempt to use "SELECT *" statements while trying to generate a plaso SQLite plugin it will break the tool since it is creating attributes based on the column names from the SELECT statement.

This is a fix for #71

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.11%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   84.75%   84.63%   -0.12%     
==========================================
  Files          28       28              
  Lines        1056     1061       +5     
==========================================
+ Hits          895      898       +3     
- Misses        161      163       +2
Impacted Files Coverage Δ
l2tscaffolder/__init__.py 100% <100%> (ø) :arrow_up:
l2tscaffolder/scaffolders/plaso_sqlite.py 89.21% <60%> (-1.51%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98497b5...f4b71a1. Read the comment docs.