log2timeline / plaso

Super timeline all the things
https://plaso.readthedocs.io
Apache License 2.0
1.71k stars 334 forks source link

Parsers & tagging for M365 Defender portal events #4794

Open dafneb opened 8 months ago

dafneb commented 8 months ago

One line description of pull request

Parser for events and activities exported from Microsoft 365 Defender portal.

Description:

Related issue (if applicable):

Notes:

All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.

Checklist:

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 87.06294% with 37 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (ed8a139) to head (59fb297). Report is 37 commits behind head on main.

Files Patch % Lines
plaso/parsers/defender_hunting.py 88.31% 27 Missing :warning:
plaso/parsers/m365_activitylog.py 81.81% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4794 +/- ## ========================================== + Coverage 85.24% 85.25% +0.01% ========================================== Files 426 428 +2 Lines 38532 38818 +286 ========================================== + Hits 32847 33096 +249 - Misses 5685 5722 +37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joachimmetz commented 8 months ago

@dafneb I'll make some changes to make sure the code meets the style guide. I'll leave comments without tagging you in, consider them informational/educational.

joachimmetz commented 8 months ago

Some references:

joachimmetz commented 8 months ago

Looks like M365 AH defines many more tables https://github.com/MicrosoftDocs/microsoft-365-docs/tree/public/microsoft-365/security/defender

joachimmetz commented 8 months ago

Might be useful to keep notes about the format and queries somewhere. Started https://github.com/forensicswiki/wiki/pull/223/files