search

log4js-node / logFaces-HTTP

LogFaces HTTP appender for log4js-node
Apache License 2.0
6 stars 3 forks source link

Update to latest husky and commitlint #29

Closed ZachHaber closed 2 years ago

ZachHaber commented 2 years ago

validate-commit-msg has been deprecated and suggests commitlint as a replacement.

In addition, the change from escaped double quotes to single quotes in the package.json was breaking for me locally (windows).

ZachHaber commented 2 years ago

Also, side note: What are your thoughts on using prettier?

lamweili commented 2 years ago

We are using prettier in the main log4js repository. If you want, you can go ahead.

I have converted your PR to a draft. When you are done with all the devDependencies, mark it ready and I'll merge it. :hugs:

ZachHaber commented 2 years ago

@peteriman, this is no longer using the .travis.yml, correct? If so, we can remove codecov and it's script, as they are no longer used in the new workflow.

lamweili commented 2 years ago

@ZachHaber Yes, Travis CI stopped working for open source builds a long time ago. We are now using GH action that runs the build for every PR. Go ahead and clean the devDependencies.

lamweili commented 2 years ago

@ZachHaber Do you still have any more changes for this repository? Or can I sort of code freeze and prepare to release a version to npm?

ZachHaber commented 2 years ago

Yeah, i have a few more things I was planning.

lamweili commented 2 years ago

Noted. I shall hold it on.