search

log4mongo / log4mongo-java

log4j appender to MongoDB database
http://log4mongo.org
Apache License 2.0
80 stars 29 forks source link

Fix for dot bug. See log4mongo/log4mongo-java#22 #23

Closed undso closed 10 years ago

undso commented 10 years ago

Fix for dot bug. See log4mongo/log4mongo-java#22

RobertStewart commented 10 years ago

This pull request has more changes in it then just handling keys that improperly contain dots. Can you please remove the second commit from the pull request so I can merge just the first change?

I'd also like to have a unit test to prove the change works as described. I can always add one after I merge the pull request, or you could add one. Either way works for me.

One thing that surprised me about GitHub is that if you make additional commits on a branch, they automatically get added to any open pull request on that branch. So, I now create feature branches for every change that I plan to submit as a pull request. Then, I can much more easily control which commits end up in a pull request.

undso commented 10 years ago

Yes that is exactly my problem now. The 2nd commit was not for this issue. :-( I'll try to remove it from the request.

undso commented 10 years ago

OK, I revert the commit so the pull is now possible. It would be great if you can add a unit test.