BufferedMongoHandler calls threading.Thread with deamon=True raises TypeError

[StevenOP]

Unfortunately, calling threading.Thread with deamon=True (L254 of log4mongo/handlers.py) does not work in python 2.7.14. Initializing a BufferedMongoHandler instance raises the following error: TypeError: __init__() got an unexpected keyword argument 'daemon'

From what I understood, adding deamon=True is only required in Python >3.3. Everything seems to run fine when removing deamon=True from the call.

Is it maybe possible to do a quick-fix and test for python version to see whether or not deamon=True should be added to the call of threading.Thread?

(I can fix it myself for local use, but it's really useful to be able to install log4mongo on a remote server using pip)

[oz123]

@StevenOP a PR is most welcomed!

[tiendan]

Hi @oz123,

Just bumped into this issue too, and sent my PR.

Cheers, Onur

[tiendan]

Hello @oz123 ,

Thanks for the merge 👍 This issue should be resolved with the next version of the library. Just one question, are you going to modify the version number later on?

We are about to push some code to our servers, and it would be great to have this fix applied in a new version so that we can include it too 🙂

Cheers, Onur

[oz123]

Hi, I intend to realease a new version after tomorrow. If everything goes well you will get your version bump.

I am in the Barcelona Plone Conference, come say hello to other python developers!

[oz123]

Released version 1.6.2 https://pypi.python.org/pypi/log4mongo/1.6.2

[tiendan]

Thanks so much!

I would love to join the conference and your training, but I'm working during the day and it's impossible to take some days off ☹️ Enjoy the city & the conference!