search

log4mongo / log4mongo-python

python logging handler for mongo database
http://log4mongo.org
Other
111 stars 37 forks source link

Fix issue #1 and enhance compatiblity #9

Closed oz123 closed 9 years ago

oz123 commented 9 years ago

Hi, Please see attached changes. The pull request does not only fix compatibility with pymongo 3.0, rather makes log4mongo pep8 style compatible.

char0n commented 9 years ago

Hi,

If I understand correctly this pull request contains:

1.) full pep8 style compatibility 2.) full compatibility with pymongo 3.0

My question is, what about the older versions. Is it still comatible with older versions of pymongo?

oz123 commented 9 years ago

Hi, The code was tested with pymongo 2.8 (which should be compatible with 2.6) and pymongo 3. No one should really use pymongo 2.6.3 anyway.

oz123 commented 9 years ago

@char0n did you have time to review the pull request?

char0n commented 9 years ago

I'll have a look at it tonight.

On Tue, Apr 14, 2015 at 7:38 PM, Oz notifications@github.com wrote:

@char0n https://github.com/char0n did you have time to review the pull request?

— Reply to this email directly or view it on GitHub https://github.com/log4mongo/log4mongo-python/pull/9#issuecomment-92991881 .

Vladimír Gorej | CodeScale s.r.o. email: gorej@codescale.net tel: +420 777 861 279, +421 948 023 011 web: http://www.codescale.net

char0n commented 9 years ago

Ok merged. I will make a release during the weekend.

Thanks

oz123 commented 9 years ago

Yay! Thank you very much.

oz123 commented 9 years ago

@char0n, what about releasing a new version?

char0n commented 9 years ago

I did not find time for it. Can you build a new release and send me the file, and I'll upload on pypi ? I will also notice your work in project credits.

On Thu, Apr 23, 2015 at 6:00 AM, Oz notifications@github.com wrote:

@char0n https://github.com/char0n, what about releasing a new version?

— Reply to this email directly or view it on GitHub https://github.com/log4mongo/log4mongo-python/pull/9#issuecomment-95420739 .

Vladimír Gorej | CodeScale s.r.o. email: gorej@codescale.net tel: +420 777 861 279, +421 948 023 011 web: http://www.codescale.net