search

log69 / aaphoto

auto adjust photo, automatic color correction of photos
http://log69.com/aaphoto_en.html
Other
29 stars 8 forks source link

Missing files for installation #1

Closed ferki closed 11 years ago

ferki commented 11 years ago

The configure script and possibly other files needed for installation from source are missing from this repo. Could you please upload them as well? Are they the same as the ones in the v0.41 archive available on your site?

log69 commented 11 years ago

Yes, they are identical.

If you're willing to install it from source, it's best to have the sources of the dependent libs from your distribution when using Linux or a Unix like system. See the bottom of the following page below: http://log69.com/aaphoto_en.html

That says: "The following libraries are used by this program: libgomp - OpenMP for parallel programming, http://gcc.gnu.org/onlinedocs/libgomp/ libjasper - JasPer software, http://www.ece.uvic.ca/~mdadams/jasper/ libjpeg - IJG JPEG software, http://www.ijg.org/ libpng - PNG software, http://www.libpng.org/ libz - Compression library, http://www.zlib.net/"

These may come in the form as: libjpeg-dev or libjpeg-devel, libgomp-dev etc.

If you still want to have all of my build script, you can grab the archive containing everything here: http://log69.com/downloads/aaphoto_sources_all.tar.gz

ferki commented 11 years ago

Actually, I currently working on a Gentoo package which would hopefully included in the official portage tree as well. Long ago I hacked together an aaphoto-0..41 ebuild for personal use. Later I had to patch it locally to make it work with recent libpng versions (>=libpng-1.5 if I recall correctly).

Recently I discovered this repo and I saw the new 0.42 version which addresses the libpng compatibility issue (in an other way than my local patch, though - looks like I just added an #include <zlib.h> in aaphoto.c), so I thought it might be a better idea to package the latest official version, and thus downloading the source from here.

The library dependencies can be handled from within the ebuild, but I ran into the missing configure problem. As far as I see aaphoto_sources_all.tar.gz does not yet contain the 0.42 changes, nor the other archives I found on log69.com. So now I am trying to find out how it is best to proceed.

Would you recommend packaging a patched 0.41 instead? Or do you plan to release a 0.42 tar.gz? Or perhaps the missing files could be included in this repo so an up-to-date buildable state could be pulled from here anytime?

I'm willing to create pull requests if that's more convenient for you. But I would like to avoid interfering with your intentions about aaphoto so some pointers about the next steps would be very much appreciated :)

log69 commented 11 years ago

You're right, the only difference compared to the ones on my site is the libpng patch. I have to point out that I'm no longer planning to keep an updated website for this project, but instead just host the updated source here. So you should take my aaphoto website as obsolete.

I realize it's best to have the configuration scripts and files in the github repo since that became the only official updated place for it. I didn't include them here before since not much interest was shown toward the sources.

I've just uploaded the missing part to it. Does it fit your purpose now?

BTW, glad to hear about the Gentoo package.

ferki commented 11 years ago

Great! Now I can download the latest aaphoto source from here and build it easily (I only have to run autoreconf before compilation to avoid a QA notice about automake maintainer mode).

I may create some further pull requests during my preparation work (for example updating some version strings to 0.42 :).

Thank you very much for your help and for aaphoto! :)