search

logan-berner / LandsatTS

LandsatTS is an R package to facilitate retrieval, cleaning, cross-calibration, and phenological modeling of Landsat time-series data.
Other
26 stars 4 forks source link

PhantomJS dependency #12

Closed scelmendorf closed 3 years ago

scelmendorf commented 3 years ago

@jakobjassmann @logan-berner you may not want to deal with this level of minutia, but in my beta-tester role I can report that when I run through the vignette I am stuck on this line: pixel_list_test_poly <- lsat_get_pixel_centers(test_poly_sf, plot_map = "man/figures/lsat_get_pixel_centers.png")

until I install phantomJS.

The error message is perfectly clear and solved with webshot::install_phantomjs(). But maybe would be good to add to the dependencies/package setup or instructions so it is installed with the package?

IslaMS commented 3 years ago

I also get a message about phantomJS:

PhantomJS not found. You can install it with webshot::install_phantomjs(). If it is installed, please make sure the phantomjs executable can be found via the PATH variable.

But I didn't do anything about it and the extraction seems to still work?

jakobjassmann commented 3 years ago

Thanks both, this is super helpful. Seems like PhantomJS is needed to save the maps generated by lsat_get_pixel_centers() in the map view port of RStudio and that this is not automatically installed by the mapview dependency. As this is an external program not a package the user will have to carry out the installation themselves when prompted.

I added a short paragraph explaining the issues to the "Installation" section of the readme: https://github.com/logan-berner/lsatTS/commit/57e983767408511c9cf58beef1afa4a0bbc7666b

Any suggestions to expand this?